Re: [libvirt PATCH] scripts: include function versions in API definition
On Thu, Sep 23, 2021 at 04:07:17PM +0200, Victor Toso wrote:
Hi,
On Thu, Sep 23, 2021 at 11:47:58AM +0100, Daniel P. Berrangé wrote:
> In order to auto-generate more of the language binding code, it is
> desirable to know what libvirt version an API was introduced in.
> We can extract this information from the .syms files and expose
> it in the API description
>
> eg instead of
>
> <function name='virNodeNumOfDevices' file='libvirt-nodedev'
> module='libvirt-nodedev'>
>
> we now have
>
> <function name='virNodeNumOfDevices' file='libvirt-nodedev'
> module='libvirt-nodedev' version='0.5.0'>
>
> This will benefit this proposal:
>
> https://gitlab.com/libvirt/libvirt-go-module/-/merge_requests/7
>
> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
Tested-by: Victor Toso <victortoso(a)redhat.com>
Thanks, this definitely helps.
Do you think it would make sense to add version metadata to other
types such as structs and enums too?
We don't have a direct record of versions for these things, so it
is not very practical.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|