Re: [libvirt] [PATCH] Revert "LXC: show used memory as 0 when domain is not active"
On Tue, Aug 11, 2015 at 10:25:19AM +0200, Peter Krempa wrote:
On Tue, Aug 11, 2015 at 09:18:23 +0100, Daniel Berrange wrote:
> On Mon, Aug 10, 2015 at 12:49:55PM -0600, Jim Fehlig wrote:
> > This reverts commit 1ce7c1d20cfd5afb26d2dbc88201085d52415d0e,
> > which introduced a significant semantic change to the
> > virDomainGetInfo() API. Additionally, the change was only
> > made to 2 of the 15 virt drivers.
> >
> > Conflicts:
> > src/qemu/qemu_driver.c
> >
> > Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
> > ---
> > src/lxc/lxc_driver.c | 2 +-
> > src/qemu/qemu_driver.c | 12 ++++++------
> > 2 files changed, 7 insertions(+), 7 deletions(-)
>
> ACK
>
> I guess we should probably do this in the stable branch too, since I
> think it made it into the most recent release.
Erm, the change is out for a while now:
git desc 1ce7c1d20cfd5afb26d2dbc88201085d52415d0e
v1.2.6-225-g1ce7c1d
Oh yes, so it is. I'm still inclined to say we should be reverting it as
I think it is wrong. The change was based on the misleading field name
shown by virsh. The info->memory field shows the current balloon target,
and conceptually this should be equal to the max memory if the ballooon
driver is not active. As such I think it should be equal to max memory
if shutoff too.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|