Re: [Libvir] [PATCH] output virsh log to file
On Tue, May 22, 2007 at 03:15:03PM +0100, Richard W.M. Jones wrote:
Nobuhiro Itou wrote:
>>But my broader point is: What use would this feature be, since you can
>>capture the output of virsh easily using shell redirection? The Xen
>>'xm' command doesn't have this feature and I don't know if anyone
has
>>asked for it.
>
>If I use it, the redirection is no problem.
>However, when our customers are made to use virsh, it is necessary to
>explain the redirection.
>Mostly, a lot of customers do not seem to use the redirection usually.
>And, executing the command applying the redirection to customers again
>when the error occurs is troublesome of customers.
>
>Therefore, the purpose is to make it immediately correspond to
>the customer's trouble report.
Technically I think you've fixed all the problems I raised.
I really think we should be looking at either a logging library, or
(better) syslog. These problems -- like logfile maxsize, logfile
location, log rotation -- have all been solved before, and I don't
believe we should reinvent this wheel.
I'm keen to hear what others think though.
My experience with systematic logging at command line level is that
you end up polluting your file system with (hidden) log files, and while it
may be fine for a developper it's not something you want to inflict to
your customers. Also the fixed name for the log file makes it easilly
useless, a random run in the same directory will just wipe out the
data you tried to collect in a separate process.
I think having permanent systematic logging to a fixed file is not
proper, I would rather not use that.
But since the patch is relatively simple based on existing virsh logging
code, I think this could go as a command line option for virsh, for example
--log filename
where the detailed logs can then be saved if needed when a problem occurs.
I think this would avoid the main drawbacks of your proposed patch.
thanks,
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/