Re: [libvirt] [PATCH v2 07/11] tests/capabilitiestest: add RISC-V capability tests
On Thu, 2018-06-14 at 22:32 +0200, Lubomir Rintel wrote:
[...]
+{
+ "execute": "query-version",
+ "id": "libvirt-2"
+}
+
+{
+ "return": {
+ "qemu": {
+ "micro": 93,
+ "minor": 11,
+ "major": 2
+ },
+ "package": "qemu-2.12.0-0.7.rc3.fc29"
+ },
+ "id": "libvirt-2"
+}
Replies should ideally be generated against official releases built
from upstream sources. I know you could easily point out instances
of that *not* being the case in the existing data, so it's not a
blocker per-se - just pointing out how it *should* be done :)
That said, I've recently pushed some changes that unfortunately
require the data to be regenerated again, so perhaps you could take
the opportunity to pull it from a released QEMU binary? Ideally one
that you built yourself from vanilla upstream, but even a Fedora
package for 2.12.0 proper would be preferable to the above.
Everything else looks good.
--
Andrea Bolognani / Red Hat / Virtualization