Re: [libvirt] [Qemu-devel] [PATCH] qmp: Deprecate query-nodes option of query-blockstats

On 2019-01-28 16:15, Anton Kuchin wrote: > This option is broken since a6baa60807 in v2.9 and returns mostly > zeroes instead of real stats because actual querring of BlockStats s/querring/querying/ > that resides in blk is missing. > > And it makes no sense because with this option BlockDriverState-s > are iterated but BlockAcctStats belong to BlockBackend and not BDS > since 7f0e9da6f13 in v2.5 > > Signed-off-by: Anton Kuchin <antonkuchin(a)yandex-team.ru&gt; > --- [...] > @@ -577,21 +576,10 @@ BlockStatsList *qmp_query_blockstats(bool has_query_nodes, > { > BlockStatsList *head = NULL, **p_next = &head; > BlockBackend *blk; > - BlockDriverState *bs; > > /* Just to be safe if query_nodes is not always initialized */ > if (has_query_nodes && query_nodes) { > - for (bs = bdrv_next_node(NULL); bs; bs = bdrv_next_node(bs)) { > - BlockStatsList *info = g_malloc0(sizeof(*info)); > - AioContext *ctx = bdrv_get_aio_context(bs); > - > - aio_context_acquire(ctx); > - info->value = bdrv_query_bds_stats(bs, false); > - aio_context_release(ctx); > - > - *p_next = info; > - p_next = &info->next; > - } > + error_setg(errp, "Option query_nodes is deprecated"); You don't only deprecate the option here, you completely disable it ... that does not make too much sense IMHO. If it is really broken since multiple releases already and nobody complained or tried to fix it so far, I think it could be simply removed immediately. Otherwise, if it is only partly broken, please leave it in the current state (if it is not fixable), and only mark it as deprecated in the qemu-deprecated.texi and block-core.json documentation.