Re: [libvirt] [PATCH] Add migration APIs for libxl driver

> +static int > +libxlDomainMigratePerform3(virDomainPtr dom, > + const char *xmlin ATTRIBUTE_UNUSED, > + const char *cookiein ATTRIBUTE_UNUSED, > + int cookieinlen ATTRIBUTE_UNUSED, > + char **cookieout ATTRIBUTE_UNUSED, > + int *cookieoutlen ATTRIBUTE_UNUSED, > + const char *dconnuri ATTRIBUTE_UNUSED, > + const char *uri, > + unsigned long flags, > + const char *dname ATTRIBUTE_UNUSED, > + unsigned long resource ATTRIBUTE_UNUSED) > +{ > + libxlDriverPrivatePtr driver = dom->conn->privateData; > + char *hostname = NULL; > + int port; > + char *servname = NULL; > + struct addrinfo hints, *res; > + int sockfd = -1; > + int ret = -1; > + > + virCheckFlags(LIBXL_MIGRATION_FLAGS, -1); > + > + libxlDriverLock(driver); > + > + if (doParseURI(uri, &hostname, &port)) > + goto cleanup; > + > + VIR_DEBUG("hostname = %s, port = %d", hostname, port); > + > + if (virAsprintf(&servname, "%d", port ? port : DEFAULT_MIGRATION_PORT) < 0) { > + virReportOOMError(); > + goto cleanup; > + } > + > + if ((sockfd = socket(AF_INET, SOCK_STREAM, 0)) < 0 ){ > + libxlError(VIR_ERR_OPERATION_FAILED, > + _("Failed to create socket")); > + goto cleanup; > + } > + > + memset(&hints, 0, sizeof(hints)); > + hints.ai_family = AF_INET; > + hints.ai_socktype = SOCK_STREAM; > + if (getaddrinfo(hostname, servname, &hints, &res) || res == NULL) { > + libxlError(VIR_ERR_OPERATION_FAILED, > + _("IP address lookup failed")); > + goto cleanup; > + } > + > + if (connect(sockfd, res->ai_addr, res->ai_addrlen) < 0) { > + libxlError(VIR_ERR_OPERATION_FAILED, > + _("Connect error")); > + goto cleanup; > + } > + > + ret = doMigrateSend(dom, flags, sockfd); > > Hmm, the entire driver is locked during the migration. I just noticed libxlDomainSave{Flags} also holds the driver lock during save :-(. libxlDomainCoreDump drops the lock during the dump and IMO migration should follow the same pattern.