Re: [libvirt] iSCSI Multi-IQN (Libvirt Support)
On Thu, Oct 22, 2009 at 03:33:37PM -0400, Laine Stump wrote:
On 10/22/2009 03:05 PM, Cole Robinson wrote:
>Looks like the patch was mangled. Just pasting the patch into your
>client probably won't be sufficient. I'd recommend git format-patch and
>git send-email, or just attach the patch file.
>
>
Actually, I found out earlier today that when a patch is sent as an
attachment, and I reply to that message message using Thunderbird, the
attachment isn't included in the reply (and so obviously isn't sitting
there quoted), making it more difficult to comment.
Either that's a Thunderbird bug, or the attachment isn't text/plain.
Sometimes mailers use silly things like text/x-patch and that confuses
things. Sending them inline is safest if using a decent editor which
can insert files without line wrapping, or using git-send-email
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|