Re: [libvirt] [PATCH v4] graphics: add support for action_if_connected in qemu

On 07/07/2011 02:59 AM, Michal Privoznik wrote: > On 06.07.2011 00:34, Eric Blake wrote: >> >> This patch changes the .xml, but not the corresponding .args file, which >> to me says it is probably incomplete. We covered the case of changing >> the attribute affecting qemu_hotplug: >> >> > No. This is purely QMP thing. qemu -spice does not have any option for > setting this (the current git version at least). That .xml vs .args > change: I've changed .xml so we can test RNG scheme. There is nothing to > add to .args. Ah, that makes sense now. This is not a qemu attribute associated with the spice device, rather it is a feature of the hotplug command (when hotplugging, what action to take in this condition). As such, I think you are right that there is no change to any .args file, so ACK to this patch as-is. That said, Jirka's proposed patch for introducing a monitor-proxy[1] sounds like it would be an awesome way to enhance our testsuite coverage. It would be nice to write up a test-stub proxy that pretends to be an active qemu monitor, but which functions even without running a real qemu process. In that way, we could get further exposure that the monitor commands that we are generating match our expectations. [1] https://www.redhat.com/archives/libvir-list/2011-July/msg00028.html