Re: [libvirt] [PATCH go v2] Add support for perf events

On Fri, Feb 24, 2017 at 15:22:51 +0530, Nitesh Konkar wrote: > Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com&gt; > --- > connect.go | 54 ++++++++++++++++++++++++++++++ ++++++++++++++++++++++++ > domain.go | 54 ++++++++++++++++++++++++++++++ ++++++++++++++++++++++++ > domain_compat.h | 36 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 144 insertions(+) The files are improperly indented. The go files use tabs for indentation while your code uses spaces. I've already pointed this out in v1.

> > diff --git a/connect.go b/connect.go > index 3c53485..e24cf66 100644 > --- a/connect.go > +++ b/connect.go > @@ -2264,6 +2264,24 @@ type DomainStatsPerf struct { > StalledCyclesBackend uint64 > RefCpuCyclesSet bool > RefCpuCycles uint64 > + CpuClockSet bool > + CpuClock uint64 > + TaskClockSet bool > + TaskClock uint64