Re: [libvirt] [PATCH] Java bindings for domain events

On Mon, Nov 17, 2008 at 03:55:13PM -0500, David Lively wrote:

Functionally this all looks fine. From a style point of view, we should keep consistency with the other virEventAddHandle func in terms of typing / param ordering. I prefer to have a typedef for the 'freefunc', even though its trivial, because I hate reading function prototypes :-) Whether we have the freefunc, before or after the 'void opaque' in the register method I don't really mind one way or the other as long as we're consistent. Having the freefunc last is probably best, since its very often just going to be NULL. Daniel