Re: [PATCH 4/4] ci: Run test suite on macOS

On Fri, Nov 20, 2020 at 08:10:57AM +0100, Michal Privoznik wrote: > On 11/13/20 8:08 PM, Andrea Bolognani wrote: >> On Fri, 2020-11-13 at 16:58 +0100, Michal Privoznik wrote: >>> On 11/8/20 10:24 PM, Roman Bolshakov wrote: >>>> - - if test "$(uname)" = "FreeBSD"; then ninja -C build dist; fi >>>> - - if test "$(uname)" = "Darwin"; then ninja -C build && ninja -C build install; fi >>>> + - ninja -C build dist >>> >>> If we go with --timeout-multiplier= as I'm suggesting in 3/4 then this >>> can't be ninja, but meson. I'm not sure what the whole point of 'ninja' >>> is at this point, sorry. >> >> ninja is the low-level tool, so in some cases (notably running the >> test suite) having meson call ninja instead of invoking the latter >> directly can enable additional features. > > And I guess that's my problem with it. The --timeout-multiplier= is argument > of meson, but if I want to run a single threaded build (useful if I mess up > something in a header file that's included from everywhere) there's no way > to pass "-j1" to meson and I have to use ninja. But guess what, ninja > doesn't accept --timeout-multiplier (nor does its -h output suggest > something of that kind). I'd understand if one was "user friendly" interface > of the other, but that doesn't seem to be the case. > I guess I'm annoyed with having to use different tool each time. > > Michal > Hi Michal, My intention with the patch was to remove the difference (skipping tests on macOS) that is no longer needed. FreeBSD had the most concise invocation, so I kept it. It's not trouble for me to update it to "meson dist" [1] if you think it's more flexible (available since 0.52.0).