Re: [libvirt] [PATCHv2 5/5] storage: test backing chain traversal

On 02/15/2013 03:26 PM, Peter Krempa wrote: I did one more thing to strengthen the test; I'm squashing this before pushing. diff --git i/tests/virstoragetest.c w/tests/virstoragetest.c index 6b4ca99..9da58f3 100644 --- i/tests/virstoragetest.c +++ w/tests/virstoragetest.c @@ -228,8 +228,16 @@ testStorageChain(const void *args) fprintf(stderr, "call should have failed\n"); goto cleanup; } - if (data->flags & EXP_WARN) + if (data->flags & EXP_WARN) { + if (!virGetLastError()) { + fprintf(stderr, "call should have warned\n"); + goto cleanup; + } virResetLastError(); + } else if (virGetLastError()) { + fprintf(stderr, "call should not have warned\n"); + goto cleanup; + } elt = meta; while (elt) { @@ -498,10 +506,10 @@ mymain(void) /* Qcow2 file with backing protocol instead of file */ const testFileData chain11[] = { qcow2_protocol }; TEST_CHAIN(11, "qcow2", absqcow2, VIR_STORAGE_FILE_QCOW2, - chain11, EXP_WARN, - chain11, ALLOW_PROBE | EXP_WARN, - chain11, EXP_WARN, - chain11, ALLOW_PROBE | EXP_WARN); + chain11, EXP_PASS, + chain11, ALLOW_PROBE | EXP_PASS, + chain11, EXP_PASS, + chain11, ALLOW_PROBE | EXP_PASS); /* qed file */ const testFileData chain12a[] = { raw }; -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org