Re: [libvirt] [PATCH v8 0/5] nodeinfo: Add support for subcores
Thanks for adding new test cases and the rework Andrea.
I have reviewed all the paches and find them good except in Patch 1
where I am leaving a
comment.
Test results are good.
The nodeinfo behaviour on a Power host with all subcores-per-core mode settings
http://ur1.ca/naalk
The nodeinfo output on a Power host having a socket deconfigured and
all subcores-per-core settings.
http://ur1.ca/nai3q
On Mon, Jul 27, 2015 at 1:38 PM, Andrea Bolognani <abologna(a)redhat.com> wrote:
Changes from v7 to v8:
* shortened test names so that make dist doesn't
stop working again
Shivaprasad is testing the series on his own hardware and
will hopefully give us some feedback soon. This new version
only changes the names of the test cases, so no need to
test the whole series again ;)
Cheers.
Andrea Bolognani (3):
tests: Add subcores1 nodeinfo test
tests: Add subcores2 nodeinfo test
tests: Add subcores3 nodeinfo test
Shivaprasad G Bhat (2):
nodeinfo: Fix output on PPC64 KVM hosts
tests: Prepare for subcore tests
src/libvirt_private.syms | 1 +
src/nodeinfo.c | 144 ++++++++++++++++++++-
src/nodeinfo.h | 1 +
tests/Makefile.am | 6 +
.../nodeinfodata/linux-ppc64-deconf-cpus.expected | 2 +-
tests/nodeinfodata/linux-ppc64-subcores1.cpuinfo | 105 +++++++++++++++
tests/nodeinfodata/linux-ppc64-subcores1.expected | 1 +
tests/nodeinfodata/linux-ppc64-subcores2.cpuinfo | 45 +++++++