Re: [libvirt] [PATCH 03/10] cleanup: Don't include libvirt/libvirt.h

On Tue, Apr 16, 2013 at 09:41:45PM +0800, Osier Yang wrote: > Which is already included by "internal.h", later patch will add > syntax-check to avoid it. > --- > src/nodeinfo.h | 1 - > src/phyp/phyp_driver.c | 1 - > src/remote/remote_protocol.x | 1 - > src/util/virkeycode.h | 1 - > 4 files changed, 4 deletions(-) > diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x > index b957b8e..d384225 100644 > --- a/src/remote/remote_protocol.x > +++ b/src/remote/remote_protocol.x > @@ -36,7 +36,6 @@ > * 'REMOTE_'. This makes names quite long. > */ > > -%#include <libvirt/libvirt.h> > %#include "internal.h" > %#include <arpa/inet.h> > This has broken make check GEN remote_protocol-struct --- remote_protocol-structs 2013-04-11 18:02:02.445662659 +0100 +++ remote_protocol-struct-t3 2013-04-17 11:57:29.472083827 +0100 @@ -7,6 +7,7 @@ VIR_TYPED_PARAM_DOUBLE = 5, VIR_TYPED_PARAM_BOOLEAN = 6, VIR_TYPED_PARAM_STRING = 7, + VIR_TYPED_PARAM_LAST = 8, }; struct remote_nonnull_domain { remote_nonnull_string name; make[2]: *** [remote_protocol-struct] Error 1