Re: [libvirt PATCH v2] docs: introduce a page showing a overall CI dashboard
On Mon, 2020-05-11 at 10:49 +0100, Daniel P. Berrangé wrote:
On Thu, May 07, 2020 at 07:08:52PM +0200, Andrea Bolognani wrote:
> On Thu, 2020-05-07 at 15:29 +0100, Daniel P. Berrangé wrote:
> > + * - ruby-libvirt
> > + - .. image::
https://gitlab.com/libvirt/ruby-libvirt/badges/master/pipeline.svg
> > + :target: https://gitlab.com/libvirt/ruby-libvirt/pipelines
> > + :alt: ruby-libvirt pipeline status
>
> Seriously though, why is this one not called libvirt-ruby? :)
I'd consider it mostly a historical accident. The actual tarball created
is ruby-libvirt-$VER.tar.gz, so the repo follows that.
For the perl though, we're call perl-Sys-Virt-$VER.tar.gz, but the repo
is libvirt-perl.
I've almost renamed the Ruby repo on a number of occassions but never
went through with it.
I'd say the move to GitLab is as good an excluse as any :) Can we
make it happen?
> > +
> > +th p, td p {
> > + margin-top: 0px;
> > + margin-bottom: 0px;
> > +}
>
> This hunk is unrelated and should go in a separate patch.
It *is* related, because without this the tables in this new page get
rendered which huge whitespace gaps, due to rst putting a <p> tag
inside each cell.
I know, but we already have reStructuredText-generated tables in our
documentation, all of which exhibit the layout issue you describe.
So it should be its own patch, which you can merge before this one.
--
Andrea Bolognani / Red Hat / Virtualization