Re: [libvirt] [PATCHv4 17/51] snapshot: reflect new dumpxml and list options in virsh
On 09/01/2011 10:24 PM, Eric Blake wrote:
New flag bits are worth exposing via virsh. In the case of
snapshot-list --roots, it's possible to emulate this even when
talking to an older server that lacks the bit; whereas
--metadata requires a newer server.
-=item B<snapshot-dumpxml> I<domain> I<snapshot>
+If I<--roots> is specified, the list will be filtered to just snapshots
+that have no parents; this option is not compatible with I<--parent>.
+
+If I<--metadata> is specified, the list will be filtered to just
+snapshots that involve libvirt metadata, and thus would interfere in
+using the B<undefine> or B<destroy> commands on that domain.
Needs a slight tweak in wording, per the results of the v3 review. I
missed this in my rebase creating v4, so I'm squashing this in now:
diff --git i/tools/virsh.pod w/tools/virsh.pod
index 3ae7321..3d468f3 100644
--- i/tools/virsh.pod
+++ w/tools/virsh.pod
@@ -1720,8 +1720,9 @@ If I<--roots> is specified, the list will be
filtered to just snapshots
that have no parents; this option is not compatible with I<--parent>.
If I<--metadata> is specified, the list will be filtered to just
-snapshots that involve libvirt metadata, and thus would interfere in
-using the B<undefine> or B<destroy> commands on that domain.
+snapshots that involve libvirt metadata, and thus would prevent
+B<undefine> of a persistent domain, or be lost on B<destroy> of
+a transient domain.
=item B<snapshot-dumpxml> I<domain> I<snapshot>
[I<--security-info>]
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org