On Mon, Jan 26, 2015 at 03:38:04PM +0100, Michal Privoznik wrote:
Up until now there are just two ways how to specify UEFI paths to
libvirt. The first one is editing qemu.conf, the other is editing
qemu_conf.c and recompile which is not that fancy. So, new
configure option is introduced: --with-loader-nvram which takes a
list of pairs of UEFI firmware and NVRAM store. This way, the
compiled in defaults can be passed during compile time without
need to change the code itself.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
configure.ac | 17 +++++++++++++++++
src/qemu/qemu_conf.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
tests/domaincapstest.c | 15 ++++++++-------
3 files changed, 74 insertions(+), 7 deletions(-)
diff --git a/configure.ac b/configure.ac
index f370475..b121777 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2789,6 +2789,23 @@ AC_ARG_WITH([default-editor],
[DEFAULT_EDITOR=vi])
AC_DEFINE_UNQUOTED([DEFAULT_EDITOR], ["$DEFAULT_EDITOR"], [Default editor to
use])
+AC_ARG_WITH([loader-nvram],
+ [AS_HELP_STRING([--with-loader-nvram],
+ [Pass list of pairs of <loader>:<nvram> paths. Both
+ pairs and list items are separated by a colon.
+ @<:default=paths to OVMF and its clones@:>@])],
+ [if test "$withval" = "no"; then
+ withval=""
+ else
+ l=`echo $withval | tr ':' '\n' | wc -l`
+ if test "$((l % 2))" -ne 0; then
Sorry for the confusion I caused to you, but I'd rather you use "`expr
$l % 2`".
ACK with that changed, my ACK to 2/2 still stands.