Re: [libvirt] [PATCH 1/8] conf: domcaps: Add 'backingStoreInput' domain capability

On 11/18/19 12:02 PM, Peter Krempa wrote: > Historically we've only supported the <backingStore> as an output-only > element for domain disks. The documentation states that it may become > supported on input. To allow management apps detectin once that happens > add a domain capability which will be asserted if the hypervisor driver > will be able to obey the <backingStore> as configured on input. > > Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; > --- > docs/formatdomaincaps.html.in | 7 +++++++ > docs/schemas/domaincaps.rng | 9 +++++++++ > src/conf/domain_capabilities.c | 1 + > src/conf/domain_capabilities.h | 1 + > tests/domaincapsdata/libxl-xenfv.xml | 1 + > tests/domaincapsdata/libxl-xenpv.xml | 1 + Now that I look closer, this patch illustrates one of the issues with the pattern of virDomainCapsFeaturesInitUnsupported : that function is used in the bhyve driver, but this patch doesn't update the bhyve test suite domcaps output. devs can't add a new domcaps feature without having to regenerate test output for every driver, which is a pain and easy to overlook.