On Mon, Nov 14, 2011 at 09:29:59PM -0700, Eric Blake wrote:
Drivers were inconsistent when presented both --live and --config
at once. For example, within qemu, getting memory parameters
favored live, while getting blkio tuning favored config. Some,
but not all, attempts to mix flags on query were filtered at
the virsh level, but we shouldn't have to duplicate efforts in
every client app. So, it is simpler to just enforce that the two
flags cannot both be used at once on query operations, which has
precedence, and which matches the documentation of
virDomainModificationImpact.
* src/libvirt.c (virDomainGetMemoryParameters)
(virDomainGetBlkioParameters)
(virDomainGetSchedulerParametersFlags, virDomainGetVcpuPinInfo):
Borrow sanity checking from virDomainGetVcpusFlags.
---
src/libvirt.c | 36 ++++++++++++++++++++++++++++++++----
1 files changed, 32 insertions(+), 4 deletions(-)
ACK
Daniel
--
|:
http://berrange.com -o-
http://www.flickr.com/photos/dberrange/ :|
|:
http://libvirt.org -o-
http://virt-manager.org :|
|:
http://autobuild.org -o-
http://search.cpan.org/~danberr/ :|
|:
http://entangle-photo.org -o-
http://live.gnome.org/gtk-vnc :|