Re: [libvirt PATCH v2 5/5] qemu_migrate: Do not forbif vDPA devices if can query blockers

On Wed, Jul 20, 2022 at 13:11:57 +0200, Eugenio Perez Martin wrote: > On Wed, Jul 20, 2022 at 12:36 PM Jiri Denemark <jdenemar(a)redhat.com&gt; wrote: > > > > On Wed, Jul 20, 2022 at 11:11:54 +0200, Eugenio Pérez wrote: > > > vDPA devices will be migratable soon. Since they are not migratable > > > before qemu 6.0, and qemu pre-6.0 didn't have the capability of asking > > > for migration blockers, let it hardcoded in that case. > > > > > > Otherwise, ask qemu about the explicit blocker. > > > > > > Signed-off-by: Eugenio Pérez <eperezma(a)redhat.com&gt; > > > --- > > > src/qemu/qemu_migration.c | 7 +++++-- > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c > > > index 4224339f39..2f5c1d8121 100644 > > > --- a/src/qemu/qemu_migration.c > > > +++ b/src/qemu/qemu_migration.c > > > @@ -1454,9 +1454,11 @@ qemuMigrationSrcIsAllowed(virQEMUDriver *driver, > > > int pauseReason; > > > size_t i; > > > int r; > > > + bool blockedReasonsCap = virQEMUCapsGet(priv->qemuCaps, > > > + QEMU_CAPS_MIGRATION_BLOCKED_REASONS); > > > > Wrong indentation of the second line (QEMU... should be aligned with > > priv). > > > > I'm fine with that indentation, but that will be a line with more than 80 chars. The max 80 columns limitation is only a soft limit. We prefer way more to keep alignment and readability of the code rather than stick to the antiquated 80 columns limit.