Re: [libvirt] [PATCH v2] qemu: Warning prompt if invalid dump image format specified

>> +++ b/src/qemu/qemu_driver.c >> @@ -4806,16 +4806,15 @@ getCompressionType(struct qemud_driver *driver) >> if (driver->dumpImageFormat) { >> compress = >> qemudSaveCompressionTypeFromString(driver->dumpImageFormat); >> if (compress< 0) { >> - qemuReportError(VIR_ERR_OPERATION_FAILED, "%s", >> - _("Invalid dump image format specified in " >> - "configuration file, using raw")); >> + VIR_WARN("Invalid dump image format '%s' specified in " >> + "configuration file, using raw", >> + driver->dumpImageFormat); > > I'm not sure what the best approach is here - requiring translation for > all VIR_WARN seems awkward, but so does nwfilter's workaround just to > avoid a syntax-check rule. Maybe we need a dedicated helper method that > requires translation but has the same effect as VIR_WARN, which both > nwfilter and this code can use. > Didn't noticed nwfilter driver translates messages for VIR_WARN, good to known it. But all the VIR_WARN in qemu driver doesn't translate it. so, will it be fine to push the this patch first, and make dedicated helper method later as another patch? :-)