Re: [libvirt] [PATCH] PHYP: Checking for NULL values when building new guest
2010/8/24 Eduardo Otubo <otubo(a)linux.vnet.ibm.com>:
> memory and maxmem might be 0 when the user sets the to 0 in the
domain
> XML. IMHO comparing> 0 is cleaner here.
I already submitted the patch v2 with this fix and I didn't understand
exactly this comparison > 0. Memory should be greater than zero, right?
Hence, if memory < 0, then ERROR. Right? If not, could you explain the
reasons?
Thanks,
Sorry, that's my fault. def->memory and def->maxmem are unsigned so
your original check using "!" was perfectly fine.
Matthias