Re: [libvirt] [PATCH 1/3] Allow use of a private dbus bus connection
On Fri, Oct 11, 2013 at 10:36:37AM -0600, Eric Blake wrote:
On 10/11/2013 09:19 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange(a)redhat.com>
>
> The dbus_bus_get() function returns a shared bus connection that
> all libraries in a process can use. You are forbidden from calling
> close on this connection though, since you can never know if any
> other code might be using it.
Doesn't that mean that multiple calls to dbus_bus_get() return the same
shared bus when possible rather than creating a new one? Thus, how
would you run out of resources if no new bus is created on the second
call? Or is it a case of a new bus per set of different arguments,
where we are consuming lots of shared buses by passing different
arguments every time?
The issue is that the call is made in the libvirt_lxc process,
and there's one of those per guest. So we have multiple connections.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|