Re: [Libvir] [PATCH] Fix string handling in virDomain{Get, Set}SchedulerParameters

"Richard W.M. Jones" <rjones(a)redhat.com&gt; wrote: > Let's try this updated patch. Hi Rich, It'd be nice to factor those "cap" and "weight" literal strings all the way out, so each is defined in exactly one place. Either with a file-scoped const declaration, e.g., static const char *cap_str = "cap"; or a cpp define: #define CAP_STR "cap"; Then, there's no risk (however small) of changing one of the literal strings without changing its mate.