Re: [PATCH V2 0/4] Handle physical address bits

On 7/29/22 21:34, Jim Fehlig wrote: > Hi All, > > This is a V2 of Dario's old patches adding support for specifying the > virtual CPU address size in bits > > https://listman.redhat.com/archives/libvir-list/2020-October/210901.html > > I've rebased those patches to latest master and tweaked them a bit. E.g. > I removed the qemucaps code since phys-bits and host-phys-bits have been > around before the minimum qemu version supported by libvirt. I also added > patches to expose the number of host address bits and ensure ABI stability > as requested in the old review comments. > > Dario Faggioli (2): > conf: Add support for specifying CPU max physical address size > qemu: Add support for max physical address size > > Jim Fehlig (2): > capabilities: Report number of host CPU physical address bits > cpu conf: Check ABI stability of CPU maxphysaddr config > Dario, Jim, I've went through the patches and they look good. I made couple of suggestions. Proposed diffs live as a fixup commits on my local branch. So if you agree with my suggestions I can just squash them before pushing. Does that work for you?