Re: [libvirt] [PATCH V2 2/3] Add a file descriptor set to QEMU private domain struct

On 02/01/2013 02:57 PM, Stefan Berger wrote: I think I mentioned this in another thread, and know I mentioned in IRC, but just for archival purposes: This version is overkill; we don't need a bitmap, but can instead just track a per-vm counter that we increment each time we allocate a new fdset (which won't be often enough to worry about overflow). On libvirtd reload, we can recompute the maximum in-use fdset, and set the counter one greater. Qemu won't care if hotunplugging leaves lower-valued fdsets unused, nor if we reuse an fdset across a libvirtd restart that was previously abandoned prior to the libvirtd restart. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org