Re: [libvirt] [PATCH] add the check whether the domain has already used a disk which attach

> On Wed, Nov 05, 2008 at 10:05:14AM +0900, S.Sakamoto wrote: > > Hi, > > > > "attach-disk" does not give an error, > > when the domain which is attached has already used the source which attach. > > This has danger of the data corruption. > > > > I make the patch to add the check of this. > > This patch outputs an error, > > when the domain which is attached has already used the source which attach. > > What hypervisor were you testing with ? AFAIR, XenD should already raise > an appropriate error in this scenario. > XenD Don't check this when I confirm it in xen(cs 18756:5fd51e1e9c79). Therefore, I think that it had better add check to virsh.c, because this should be checked whether xen or qemu.