Re: [libvirt] [PATCH 2/2] qemu: agent: fix unsafe agent access

qemuDomainObjExitAgent is unsafe. First it accesses domain object without domain lock. Second it uses outdated logic that goes back to commit 79533da1 of year 2009 when code was quite different. (unref function instead of unreferencing only unlocked and disposed object in case of last reference and leaved unlocking to the caller otherwise). Nowadays this logic may lead to disposing locked object i guess.

Another problem is that the callers of qemuDomainObjEnterAgent use domain object again (namely priv->agent) without domain lock.

This patch address these two problems. qemuDomainGetAgent is dropped as unused. --- I wonder should we make qemuDomainObj(Enter|Exit)Agent be macros. So we don't need to declare a variable to hold agent reference and zero it out at the end for safety. Also the qemu monitor code has probably same problems as the agent monitor code seems to be copied from there.

src/qemu/qemu_domain.c | 41 ++++--------- src/qemu/qemu_domain.h | 7 +-- src/qemu/qemu_driver.c | 153 ++++++++++++++++++++++++------------------------- 3 files changed, 91 insertions(+), 110 deletions(-)