Re: [libvirt] [PATCH 04/22] virsh: Enhance documentation of cpu-models command
On Wed, May 16, 2018 at 10:39:23AM +0200, Jiri Denemark wrote:
Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
---
tools/virsh.pod | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index 5f72e11dec..5fc8201893 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -599,7 +599,13 @@ incompatibility will be printed out.
=item B<cpu-models> I<arch>
-Print the list of CPU models known for the specified architecture.
+Print the list of CPU models known by libvirt for the specified architecture.
+Whether a specific hypervisor is able to create a domain which uses any of
+the printed CPU models is a separate question which can be answered by
+looking the domain capabilities XML returned by B<domcapabilities> command.
s/looking the/looking at the/
+Moreover, for some architectures libvirt does not know any CPU
models and
+the usable CPU models are only limited by the hypervisor.
Wonder if it is worth adding a small example for the above.
This command will
+print that all CPU models are accepted for these architectures.
s/CPU models are accepted/CPU models that are accepted/
=item B<echo> [I<--shell>] [I<--xml>] [I<arg>...]
With the nits addresed:
Reviewed-by: Kashyap Chamarthy <kchamart(a)redhat.com>
--
/kashyap