On 09/05/2011 05:02 PM, Eric Blake wrote:
On 09/05/2011 06:33 AM, Peter Krempa wrote:
> Patch e81778d6184f1850a10eb661eb756b50421d5ac4 introduces printing
> file name on XML errors. This corrects the URL string to be NULL and
> therefore to print an error message not containing bogus filename
> "domain.xml".
>
> NULL is a valid parameter for the file name value, as the only usage is
> for error handlers. Functions touching the value either in libxml2 or in
> libvirt check this parameter for NULL and behave according to it.
> ---
> src/conf/domain_conf.c | 2 +-
> src/security/virt-aa-helper.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
I still think a lot of the virXMLParseStringCtxt() calls in virsh.c
need the same treatment.
Uhm, yes. You're right. I forgot about that.
I'll post another patch to this series.