Re: [libvirt] [re-send][PATCH 1/3] add qemu driver hook
在 2012-10-08一的 20:05 -0600，Eric Blake写道：
On 10/08/2012 07:51 PM, liguang wrote:
> this hook aimed at migration only, it supposed
> to be used as a helper of migrate --copy-storage-*
> features to remove the unreasonable limitation
> of pre-exist disk images at migration target.
> someone can add more functions to hook files.
NACK. Instead of writing a hook that runs outside of libvirt and has to
be installed to be of use, we should instead fix libvirt to do the file
creation itself. That is, you should be patching
src/qemu/qemu_migration.c to detect when copy-storage-* has been passed,
really? sorry, I don't know any implicit libvirt development rules,
but, as I see, there are none hooks used by libvirt until now, why
don't we use them instead of just design and obsolete?
can't hooks be installed just like other libvirt files?
then, create files by python or c have difference?
and to then pre-create the proper empty files and give them correct
SELinux labels.
--
liguang lig.fnst(a)cn.fujitsu.com
FNST linux kernel team