Re: [libvirt] [PATCH 2/2] qemu: Drop emitBootindex parameter
On Wed, Jun 29, 2016 at 09:20:05AM +0200, Jiri Denemark wrote:
On Wed, Jun 29, 2016 at 08:32:50 +0200, Ján Tomko wrote:
> On Tue, Jun 28, 2016 at 11:17:35PM +0200, Jiri Denemark wrote:
> >Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
> >---
> > src/qemu/qemu_command.c | 75 ++++++++++++++++++++++---------------------------
> > 1 file changed, 34 insertions(+), 41 deletions(-)
> >
> >@@ -8030,7 +8025,7 @@ qemuBuildNetCommandLine(virCommandPtr cmd,
> > if (def->nnets) {
> > unsigned int bootNet = 0;
> >
> >- if (emitBootindex) {
> >+ if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_BOOTINDEX)) {
>
> This will override net->info.bootindex.
Could you spend just a tiny bit more words describing what you think
this hunk will break?
No ;)
Jan