Re: [libvirt] [PATCH] virnettlscontexttest fails with GNUTLS 3.0.28

On 12/19/2013 09:23 AM, Cédric Bosdonnat wrote: > Changed the constraints on gnutls to 3.1+ > --- > tests/virnettlscontexttest.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c > index fc512fc..d9a4e9d 100644 > --- a/tests/virnettlscontexttest.c > +++ b/tests/virnettlscontexttest.c > @@ -268,7 +268,8 @@ mymain(void) > * be rejected. GNUTLS < 3 does not reject it and > * we don't anticipate them changing this behaviour > */ > - DO_CTX_TEST(true, cacert4req.filename, servercert4req.filename, GNUTLS_VERSION_MAJOR >= 3); > + DO_CTX_TEST(true, cacert4req.filename, servercert4req.filename, > + GNUTLS_VERSION_MAJOR >= 3 && GNUTLS_VERSION_MINOR >= 1); Not quite. This will reject gnutls 4.0. It has to be more like: (GNUTLS_VERSION_MAJOR == 3 && GNUTLS_VERSION_MINOR >= 1) || GNUTLS_VERSION_MAJOR > 3 What distro were you on when you hit this failure? I'm a little bit reluctant to bump the minimum requirement without knowing a bit more about how common 3.0 is in practice. Adding more details in your commit log about why you needed it (not just what you changed) makes it easier to review.