Re: [libvirt] [PATCH 13/16] snapshot: Rename file for virDomainMomentObj

On 3/20/19 1:41 AM, Eric Blake wrote: > Now that we have made virDomainMomentObj sufficiently generic to > support both snapshots and checkpoints, it is time to rename the file > that it lives in. The split between a generic object and a list of the > generic objects doesn't buy us as much, so it will be easier to stick > all the moment list code in one file, with more code moving in the > next patch. > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > --- > ...snapshotobj.h => virdomainmomentobjlist.h} | 26 ++++++++++--------- > src/conf/virdomainsnapshotobjlist.h | 7 ++++- > src/conf/Makefile.inc.am | 4 +-- > ...snapshotobj.c => virdomainmomentobjlist.c} | 12 ++++----- > src/libvirt_private.syms | 18 ++++++------- > 5 files changed, 37 insertions(+), 30 deletions(-) > rename src/conf/{virdomainsnapshotobj.h => virdomainmomentobjlist.h} (72%) > rename src/conf/{virdomainsnapshotobj.c => virdomainmomentobjlist.c} (95%) > I have to say it's "weird" the order that occurs in gitk and the patches is different... IIRC you have some hook that places the .h files up front in the sent patch, but for some reason gitk has it's own freaking mind /-|

> > -#define VIR_FROM_THIS VIR_FROM_DOMAIN_SNAPSHOT > +#define VIR_FROM_THIS VIR_FROM_DOMAIN Hmm... Almost feels like we should have a VIR_FROM_DOMAIN_MOMENT, but there's only one virReportError and it's a hash lookup. Maybe something for the future.