Re: [PATCH] libxl: Turn on user aliases
On Tue, Mar 01, 2022 at 09:40:30 -0700, Jim Fehlig wrote:
On 2/17/22 04:56, Michal Privoznik wrote:
> When I implemented user aliases I've invented this
> virDomainDefFeatures flag so that individual drivers can signal
> support for user provided aliases. The reasoning was that a
> device alias might be part of guest ABI, or used in a different
> way then in QEMU. Well, neither applies to the libxl driver, so
> it's safe to allow user aliases there.
I suppose it is safe, but does it make sense since aliases are not used by
the driver in any way, and not supported by libxl?
In that case at least the libvirt side user-visible aspect of it does
make sense. Users can pick a stable alias for their device if they care
about that for any reason.
In the qemu impl we decided to propagate it to the hypervisor, but that
should be considered an implementation detail as the IDs of objects
(mostly) don't have guest visible meaning.