Re: [libvirt] [PATCH] Imprint all logs with version + package build information

On 02/02/2011 05:18 AM, Daniel P. Berrange wrote: git send-email --subject-prefix=PATCHv2 is a neat trick, as is summarizing the difference from v1. I don't have the gnulib version-etc module licensing issue sorted yet, but now that your ./configure options match those of gnulib, I'm happier with it; and I'd rather see this go in sooner than later (we can tweak it later to take advantage of gnulib, if gnulib improves). Confirm that this matches coreutils' ./configure option. That's US-centric. Can't we instead go with ISO format of year first, to avoid the ambiguities of US vs Europe on the first 12 days of a given month? And, since the .spec file runs on a system where we are guaranteed that date is POSIX-compliant, we can use the shorter: %(date +"%%F-%%T") This says the version string is logged at the same priority as the first call to virLogMessage; shouldn't it instead be a fixed priority? And if you switch to a fixed priority, should setting virLogOutputs[i].logVersion to false be dependent on whether the callback function virLogOutputs[i].f() actually output the version string? ACK with those nits addressed. -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org