Re: [PATCH v1 04/12] bhyve: monitor: Make bhyveMonitor a virClass
On Mon, Feb 24, 2020 at 01:46:16AM -0500, Ryan Moeller wrote:
This makes lifecycle management a bit easier thanks to ref counting,
and
it is closer to what the qemu driver does.
FWIW, if you want todo any more conversions in the future, note that
we're intending to replace virObject with GObject. eg as illustrated
in:
commit 16121a88a7ef933220bcf9eff6575367278a06f7
Author: Daniel P. Berrangé <berrange(a)redhat.com>
Date: Thu Sep 19 15:38:03 2019 +0100
util: convert virIdentity class to use GObject
Signed-off-by: Ryan Moeller <ryan(a)iXsystems.com>
---
src/bhyve/bhyve_monitor.c | 116 +++++++++++++++++++++++++-------------
1 file changed, 76 insertions(+), 40 deletions(-)
None the less, I'm fine taking this conversion to virObject
as is, since it is better than what currently exists.
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|