Re: [libvirt] [libvirt PATCH v2 14/44] Deprecate QEMU_CAPS_SDL
On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote:
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 009ae2d36c..18f7e6d2d7 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -1141,8 +1141,8 @@ mymain(void)
VIR_FREE(driver.config->vncSASLdir);
VIR_FREE(driver.config->vncTLSx509certdir);
- DO_TEST("graphics-sdl", QEMU_CAPS_SDL, QEMU_CAPS_DEVICE_VGA);
- DO_TEST("graphics-sdl-fullscreen", QEMU_CAPS_SDL,
+ DO_TEST("graphics-sdl", QEMU_CAPS_DEVICE_VGA);
The capability can go on a separate line now.
I think Dan's comments about having better detection of whether SDL
support is actually compiled into the QEMU binary will need to be
addressed separately anyway and thus shouldn't prevent this patch
from being merged. Assuming he doesn't object,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization