Re: [libvirt] [PATCH] Allows for a <description> tag for domains
On Wed, 2009-09-30 at 14:58 +0200, Daniel Veillard wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=523639
feature request which makes sense to me, the simple patch attached
seems to be sufficient, one can define and have the description back
in the dump. Doesn't try to keep the location of the tag, it always
get serialized after <uuid>.
The only drawbacks I can think of are:
- others XML formats may require the same, but honnestly it's trivial
- machine generated description (for example if the history log of
a domain gets stored there) could grow a lot and I wonder if we
have a hard limit on the size when transmitting xml descriptions
Oh and I didn't found a good place to test the feature, i.e. no test
seems to parse and reserialize XML it's always about conversions.
FWIW, I think a lot of this kind of info makes sense to include in the
git changelog, rather than just:
523639 Allows a <description> tag for domains
* docs/schemas/domain.rng: allow one <description> tag in the top level
of the <domain> to store user information as text
* src/conf/domain_conf.c src/conf/domain_conf.h: extend the structure
to store this text, grab it at parse time and save it back when
present after <uuid>
You can commit the patch, write the changelog, then send the patch using
git-format-patch/git-send-email and that way the reviewer sees the same
info the will go into the git changelog
Cheers,
Mark.