Re: [libvirt] [PATCH] Switch to a more extensible annotation system for RPC protocols

On 04/17/2013 09:43 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; > > Currently the RPC protocol files can contain annotations after > the protocol enum eg > > REMOTE_PROC_DOMAIN_SNAPSHOT_LIST_CHILDREN_NAMES = 247, /* autogen autogen priority:high */ > > This is not very extensible as the number of annotations grows. Hmm - wonder if that means you plan on adding annotations soon :)

> Change it to use > > /** > * @generate: both > * @priority: high > */ > REMOTE_PROC_DOMAIN_SNAPSHOT_LIST_CHILDREN_NAMES = 247, At which point grouping by 10 no longer matters.

> - VIR_LOCK_SPACE_PROTOCOL_PROC_REGISTER = 1, /* skipgen skipgen */ > - VIR_LOCK_SPACE_PROTOCOL_PROC_RESTRICT = 2, /* skipgen skipgen */ > - VIR_LOCK_SPACE_PROTOCOL_PROC_NEW = 3, /* skipgen skipgen */ > - VIR_LOCK_SPACE_PROTOCOL_PROC_CREATE_RESOURCE = 4, /* skipgen skipgen */ > - VIR_LOCK_SPACE_PROTOCOL_PROC_DELETE_RESOURCE = 5, /* skipgen skipgen */ > + /** > + * @generate: none > + */ > + VIR_LOCK_SPACE_PROTOCOL_PROC_REGISTER = 1, > + /** I think it would be nicer to put a blank line before the /** of each listing, so that it is even more visually obvious that a comment applies to the enum below it.

> + * @generate: none > + */ > + VIR_LOCK_SPACE_PROTOCOL_PROC_RESTRICT = 2, > + /** > + * @generate: none > + */ > + VIR_LOCK_SPACE_PROTOCOL_PROC_NEW = 3, > + /** > + * @generate: none > + */ > + VIR_LOCK_SPACE_PROTOCOL_PROC_CREATE_RESOURCE = 4, > + /** > + * @generate: none > + */ > + VIR_LOCK_SPACE_PROTOCOL_PROC_DELETE_RESOURCE = 5, > > - VIR_LOCK_SPACE_PROTOCOL_PROC_ACQUIRE_RESOURCE = 6, /* skipgen skipgen */ > - VIR_LOCK_SPACE_PROTOCOL_PROC_RELEASE_RESOURCE = 7, /* skipgen skipgen */ > + /** Hmm, your conversion preserved existing blank lines, but if you take my advice of adding a blank before every /**, I don't see any point in having double blanks before multiples of 5 or 10.