On 9/11/24 16:47, Jim Fehlig wrote:
On 9/11/24 16:08, Laine Stump wrote:
> On 9/11/24 5:02 PM, Jim Fehlig via Devel wrote:
>> Enhance the 'since' annotation of <filterref> documentation to
note
>> it's only supported by the QEMU, LXC, and ch hypervisor drivers.
>>
>> Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
>> ---
>> docs/formatdomain.rst | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
>> index 47d3e2125e..8e8a9660fc 100644
>> --- a/docs/formatdomain.rst
>> +++ b/docs/formatdomain.rst
>> @@ -6205,10 +6205,10 @@ hypervisor tries to reconnect.
>> Traffic filtering with NWFilter
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> -:since:`Since 0.8.0` an ``nwfilter`` profile can be assigned to a domain
>> -interface, which allows configuring traffic filter rules for the virtual
>> -machine. See the `nwfilter <formatnwfilter.html>`__ documentation for
more
>> -complete details.
>> +:since:`Since 0.8.0 (QEMU), 0.9.3 (LXC), 10.1.0 (Cloud Hypervisor)` an
>> ``nwfilter``
>> +profile can be assigned to a domain interface, which allows configuring traffic
>> +filter rules for the virtual machine. See the `nwfilter
>> <formatnwfilter.html>`__
>> +documentation for more complete details.
>
> It's preexisting, but I would have said "allows configuring network traffic
> filter rules".
I've added 'network' to that sentence in my local branch.
>
> Reviewed-by: Laine Stump <laine(a)redhat.com>
I've pushed this patch now. I'll send V2 of patch2 in a bit.
Regards,
Jim