Re: [libvirt] [PATCH 11/24] hostdev: Remove redundant check

> > If for some reason we "continue" (or not) and eventually "goto resetvfnetconfig;" > > before ever setting last_processed_hostdev_vf, then we get to the goto.,.. > >   > > >    resetvfnetconfig: > > > -    for (i = 0; > > > -         last_processed_hostdev_vf != -1 && i <= last_processed_hostdev_vf; i++) > > and last_processed_hostdev_vf still == -1 > >   > > So that check needs to be there - perhaps just add an: > >   > >      if (last_processed_hostdev_vf > -1) { > >      } > I fail to see how this is a problem: if last_processed_hostdev_vf > has never been assigned a value after being declared, then the > rewritten loop would be equivalent to >  >   for (i = 0; i <= -1; i++) { ... } >  > which means the loop body will never be executed, just as > expected. Am I missing something?   size_t i;   Coverity says:   (60) Event negative_returns:  Using unsigned variable "last_processed_hostdev_vf" in a loop exit condition.