Re: [libvirt] [PATCHv2] build: fix build on platforms without ptsname_r
On 11/08/2011 02:29 AM, Daniel P. Berrange wrote:
> Alas, this is just complicated enough that I don't feel
comfortable
> pushing it under the build-breaker rule, even though I have verified
> that it fixes builds on both FreeBSD and Cygwin, as well as still
> behaves correctly with LXC containers on Linux. Anyone willing to
> give this a review before 0.9.7 gets released?
Unfortunately it does not build on Mingw:
Aargh, and my apologies for not testing mingw after updating .gnulib.
The ultimate problem is in gnulib, and I will be fixing the gnulib
openpty module later this week to provide an openpty stub that at least
compiles, while failing with ENOSYS, rather than the current mess of
breaking a mingw compile altogether.
But for backport purposes, it would be nice to have a libvirt-only
minimal patch against the 0.9.7 tarball that works around the problem,
rather than having to do a .gnulib update and cut an 0.9.8 just for mingw.
Unless someone spots an easy patch, it looks like we'll need to do
a 0.9.8 release of libvirt to revert this code
I'm hoping we don't have to go that far; I'll post something later today
once I get my minimal patch working.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org