Re: [libvirt] [PATCH v3 5/5] qemu: Remove unnecessary virReportError on networkGetNetworkAddress return
On 03/10/2015 10:58 AM, Ján Tomko wrote:
On Mon, Mar 09, 2015 at 08:05:01PM -0400, John Ferlan wrote:
> From: Luyao Huang <lhuang(a)redhat.com>
>
> Error messages are already set in all code paths returning -1 from
> networkGetNetworkAddress, so we don't want to overwrite them.
>
> Signed-off-by: Luyao Huang <lhuang(a)redhat.com>
> Signed-off-by: John Ferlan <jferlan(a)redhat.com>
> ---
> src/qemu/qemu_command.c | 14 ++++----------
> 1 file changed, 4 insertions(+), 10 deletions(-)
>
ACK, this one does not depend on the rest of the series.
Jan
Tks - this one patch is pushed now.
I believe this will cause a change to the message in:
https://bugzilla.redhat.com/show_bug.cgi?id=1192318
from "error: XML error: listen network 'ipv6' had no usable address"
to: "...Unable to get IPv4 address on this platform"
But I have no empirical evidence.
John