Re: [libvirt] [PATCH] qemu: Unref domain on error of opening qemu monitor
On Thu, Oct 28, 2010 at 11:06:03AM +0800, Hu Tao wrote:
The domain refed will be left unrefed when there is error when
opening
qemu monitor, so unref it.
No, it won't, there is an explicit unref on failure:
priv->mon = qemuMonitorOpen(vm,
priv->monConfig,
priv->monJSON,
&monitorCallbacks);
if (priv->mon == NULL)
virDomainObjUnref(vm);
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|