Re: [libvirt] [PATCH v5 11/11] qemu: Detect pr-manager-helper capability
On 04/23/2018 09:14 AM, Michal Privoznik wrote:
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
---
src/qemu/qemu_capabilities.c | 1 +
tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 +
tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 +
tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 +
6 files changed, 6 insertions(+)
Now that the capability exists in latest, the qemuxml2argvtest requires
changes... We need to be sure to follow the new CAPS_LATEST convention
even though this works without it, was started before it, but must
capitulate so that future patches cannot point at this and say, well
this one didn't have to...
1.
git mv tests/qemuxml2argvdata/disk-virtio-scsi-reservations.args \
tests/qemuxml2argvdata/disk-virtio-scsi-reservations.x86_64-latest.args
2. edit tests/qemuxml2argvtest.c w/ diff:
- DO_TEST("disk-virtio-scsi-reservations",
- QEMU_CAPS_DRIVE_BOOT, QEMU_CAPS_VIRTIO_SCSI,
- QEMU_CAPS_SCSI_BLOCK, QEMU_CAPS_PR_MANAGER_HELPER);
+ DO_TEST_CAPS_LATEST("disk-virtio-scsi-reservations");
3. VIR_TEST_REGENERATE_OUTPUT=1 tests/qemuxml2argvtest
and add/merge into here.
or move this to earlier and do the above earlier - IDC either way, then
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John