Re: [libvirt] [PATCH] qemu:Fix snapshot creating with vm xml persistent
On Thu, Jul 26, 2018 at 03:03:04 -0400, Bobo Du wrote:
it is a bug when the vm is undefined after started.
blockcommit interface also has the bug with above.
Could you please specify steps and the outcome when this breaks?
vm->newDef should not be present if the VM is not persistent so the code
below should be correct as is now. I think there might be some other
bug.
Signed-off-by: Bobo Du <dubobo(a)didichuxing.com
Missing closing angle bracket. Please use the '-s' switch for git commit
which will add the signoff line in the correct format.
---
src/qemu/qemu_blockjob.c | 2 +-
src/qemu/qemu_driver.c | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)