Re: [libvirt] [Xen-devel] [PATCH LIBVIRT] libxl: Recognise ARM architectures

On Fri, Feb 28, 2014 at 02:12:30AM +0000, Ian Campbell wrote: > On Wed, 2014-02-26 at 15:01 +0000, Daniel P. Berrange wrote: > > Yep, if ARM has a PV console, then we'd need to add tiny bit to the XML > > to allow us to configure that explicitly, similar to how we do for KVM's > > virtio-console support. > > Do you mean I need to add something to the XML config snippet, or I need > to add some special handling in the XML parser/consumer? > > I've grepped around the virtio-console stuff and I'm none the wiser. Opps, yes, I should have explained this better, since our docs here are about as clear as mud. With traditional x86 paravirt Xen, we just have the plain paravirt console devices <console type='pty'> <target type='xen'/> </console> With x86 fullvirt Xen/KVM/QEMU, the console type just defaults to being a serial port so you would usually just add <serial type='pty'> </serial> and then libvirt would automatically add a <console> with <console type='pty'> <target type='serial'/> </console> With x86 fullvirt KVM, we also have support for virtio which is done using <console type='pty'> <target type='virtio'/> </console> So actually this leads me to ask what kind of console Arm fullvirt Xen guests actually have ? If they just use the traditional Xen paravirt console, then we just need to make sure that this works for them by default: <console type='pty'> <target type='xen'/> </console> If there's a different type of console device that's not related to the Xen paravirt console device, then we'd need to invent a new <target type='xxx'/> value for Arm.