Re: [libvirt PATCH 66/80] qemu: Handle incoming migration in qemuMigrationAnyConnectionClosed

On Tue, May 10, 2022 at 17:21:27 +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com&gt; > --- > src/qemu/qemu_migration.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c > index c0ab59f688..c1a60c90ef 100644 > --- a/src/qemu/qemu_migration.c > +++ b/src/qemu/qemu_migration.c > @@ -2378,15 +2378,12 @@ qemuMigrationAnyConnectionClosed(virDomainObj *vm, > case QEMU_MIGRATION_PHASE_POSTCOPY_FAILED: > case QEMU_MIGRATION_PHASE_BEGIN_RESUME: > case QEMU_MIGRATION_PHASE_PERFORM_RESUME: > + case QEMU_MIGRATION_PHASE_PREPARE_RESUME: > VIR_DEBUG("Connection closed while resuming failed post-copy migration"); > postcopy = true; > break; > > case QEMU_MIGRATION_PHASE_PREPARE: > - case QEMU_MIGRATION_PHASE_FINISH2: > - case QEMU_MIGRATION_PHASE_FINISH3: > - case QEMU_MIGRATION_PHASE_PREPARE_RESUME: > - case QEMU_MIGRATION_PHASE_FINISH_RESUME: What was the point of moving these to a separate section and then moving them back, where they were before?