On 07/14/2011 08:14 AM, Daniel P. Berrange wrote:
On Thu, Jul 14, 2011 at 08:11:20AM -0600, Eric Blake wrote:
> On 07/14/2011 08:08 AM, Daniel P. Berrange wrote:
>>> That would be a valid concern if we passed internal flags over the wire,
>>> but we don't.
>>
>> I'm thinking about the case where a value we currently use for an
>> internal flag, gets used for a public flag in the future. In that
>> case, any client side checks for curent internal flags would be
>> bogus.
>
> Then we already have the bogus situation, where libvirt.c is silently
> filtering out internal flags.
I wasn't aware of any existing filtering - we must remove any such
cases.
Will do - I already had a local patch started for that effort, but I can
improve it along these lines.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org